FindNakedNotify

java.lang.Object

edu.umd.cs.findbugs.visitclass.BetterVisitor

edu.umd.cs.findbugs.visitclass.PreorderVisitor

edu.umd.cs.findbugs.visitclass.AnnotationVisitor

edu.umd.cs.findbugs.visitclass.DismantleBytecode

edu.umd.cs.findbugs.BytecodeScanningDetector

edu.umd.cs.findbugs.detect.FindNakedNotify

All Implemented Interfaces:: Detector, Priorities, StatelessDetector, Cloneable, org.apache.bcel.classfile.Visitor

public class FindNakedNotify extends BytecodeScanningDetector implements StatelessDetector

Nested Class Summary

Nested Classes

Modifier and Type

Class

Description

private static enum

FindNakedNotify.Stage
Field Summary

Fields

Modifier and Type

Field

Description

private final BugReporter

bugReporter

private int

notifyPC

private FindNakedNotify.Stage

stage

private boolean

stateUpdatedBeforeSync

True when this method performed a visible state update after the previous synchronized region (or method entry) and before the current monitorenter.

(package private) boolean

synchronizedMethod

Fields inherited from class DismantleBytecode
codeBytes, lineNumberTable, M_BR, M_CP, M_INT, M_PAD, M_R, M_UINT

Fields inherited from interface Priorities
EXP_PRIORITY, HIGH_PRIORITY, IGNORE_PRIORITY, LOW_PRIORITY, NORMAL_PRIORITY
Constructor Summary

Constructors

Constructor

Description

FindNakedNotify(BugReporter bugReporter)
Method Summary

Modifier and Type

Method

Description

private void

abandonSyncRegion()

private static boolean

isWaitOrNotifyName(String name)

private void

notePossibleStateUpdate(int seen)

Remember updates that can make a following notify meaningful even when they occur outside the synchronized block (issue #3786).

private void

reportIfNakedNotify()

void

sawOpcode(int seen)

void

visit(org.apache.bcel.classfile.Code obj)

void

visit(org.apache.bcel.classfile.Method obj)

Methods inherited from class BytecodeScanningDetector
getClassContext, report, shouldVisitCode, visitClassContext

Methods inherited from class DismantleBytecode
afterOpcode, areOppositeBranches, atCatchBlock, beforeOpcode, getBranchFallThrough, getBranchOffset, getBranchTarget, getClassConstantOperand, getClassDescriptorOperand, getCodeByte, getConstantRefOperand, getDefaultSwitchOffset, getDottedClassConstantOperand, getFieldDescriptorOperand, getIntConstant, getLongConstant, getMaxPC, getMethodDescriptorOperand, getNameConstantOperand, getNextCodeByte, getNextOpcode, getNextPC, getOpcode, getPC, getPrevOpcode, getRefFieldIsStatic, getRegisterOperand, getSigConstantOperand, getStringConstantOperand, getSwitchLabels, getSwitchOffsets, getXClassOperand, getXFieldOperand, getXMethodOperand, isBranch, isIf, isMethodCall, isRegisterLoad, isRegisterStore, isRegisterStore, isReturn, isShift, isSwitch, isWideOpcode, normalizeNullComparison, printOpCode, sawBranchTo, sawClass, sawDouble, sawField, sawFloat, sawIMethod, sawInt, sawLong, sawMethod, sawRegister, sawString

Methods inherited from class AnnotationVisitor
getAnnotationParameterAsEnum, getAnnotationParameterAsString, getAnnotationParameterAsStringArray, visitAnnotation, visitAnnotation, visitParameterAnnotation, visitParameterAnnotation, visitSyntheticParameterAnnotation

Methods inherited from class PreorderVisitor
amVisitingMainMethod, asUnsignedByte, doVisitMethod, getClassDescriptor, getClassName, getCode, getConstantPool, getDottedClassName, getDottedMethodSig, getDottedSuperclassName, getField, getFieldDescriptor, getFieldIsStatic, getFieldName, getFieldSig, getFullyQualifiedFieldName, getFullyQualifiedMethodName, getMethod, getMethodDescriptor, getMethodName, getMethodSig, getMethodVisitOrder, getNumberArguments, getNumberMethodArguments, getPackageName, getSizeOfSurroundingTryBlock, getSizeOfSurroundingTryBlock, getSourceFile, getStringFromIndex, getSuperclassName, getSurroundingCaughtExceptions, getSurroundingCaughtExceptions, getSurroundingCaughtExceptionTypes, getSurroundingTryBlock, getSurroundingTryBlock, getThisClass, getXClass, getXField, getXMethod, hasInterestingClass, hasInterestingMethod, isVisitMethodsInCallOrder, setupVisitorForClass, setVisitMethodsInCallOrder, shouldVisit, toString, visitAfter, visitAfter, visitAfter, visitAnnotationDefault, visitAnnotationEntry, visitBootstrapMethods, visitCode, visitConstantInvokeDynamic, visitConstantMethodHandle, visitConstantMethodType, visitConstantModule, visitConstantPackage, visitConstantPool, visitEnclosingMethod, visitingField, visitingMethod, visitInnerClasses, visitJavaClass, visitLineNumberTable, visitLocalVariableTable, visitMethodParameters, visitParameterAnnotationEntry, visitStackMap, visitStackMapEntry

Methods inherited from class BetterVisitor
clone, report, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visitCodeException, visitConstantClass, visitConstantDouble, visitConstantFieldref, visitConstantFloat, visitConstantInteger, visitConstantInterfaceMethodref, visitConstantLong, visitConstantMethodref, visitConstantNameAndType, visitConstantString, visitConstantUtf8, visitConstantValue, visitDeprecated, visitExceptionTable, visitField, visitInnerClass, visitLineNumber, visitLocalVariable, visitLocalVariableTypeTable, visitMethod, visitSignature, visitSourceFile, visitSynthetic, visitUnknown

Methods inherited from class Object
equals, finalize, getClass, hashCode, notify, notifyAll, wait, wait, wait

Methods inherited from interface StatelessDetector
clone

Methods inherited from interface org.apache.bcel.classfile.Visitor
visitConstantDynamic, visitMethodParameter, visitModule, visitModuleExports, visitModuleMainClass, visitModuleOpens, visitModulePackages, visitModuleProvides, visitModuleRequires, visitNestHost, visitNestMembers, visitPermittedSubclasses, visitRecord, visitRecordComponent, visitStackMapType

Field Details
- stage
  
  private FindNakedNotify.Stage stage
- bugReporter
  
  private final BugReporter bugReporter
- synchronizedMethod
  
  boolean synchronizedMethod
- notifyPC
  
  private int notifyPC
- stateUpdatedBeforeSync
  
  private boolean stateUpdatedBeforeSync
  
  True when this method performed a visible state update after the previous synchronized region (or method entry) and before the current monitorenter. Volatile field stores and ordinary method calls count; plain non-volatile field stores do not (see NakedWait).
Constructor Details
- FindNakedNotify
  
  public FindNakedNotify(BugReporter bugReporter)
Method Details
- visit
  
  public void visit(org.apache.bcel.classfile.Method obj)
  
  Overrides:
  
  visit in class BetterVisitor
- visit
  
  public void visit(org.apache.bcel.classfile.Code obj)
  
  Overrides:
  
  visit in class DismantleBytecode
- sawOpcode
  
  public void sawOpcode(int seen)
  
  Overrides:
  
  sawOpcode in class DismantleBytecode
- notePossibleStateUpdate
  
  private void notePossibleStateUpdate(int seen)
  
  Remember updates that can make a following notify meaningful even when they occur outside the synchronized block (issue #3786).
- isWaitOrNotifyName
  
  private static boolean isWaitOrNotifyName(String name)
- reportIfNakedNotify
  
  private void reportIfNakedNotify()
- abandonSyncRegion
  
  private void abandonSyncRegion()